diff --git a/superset-frontend/spec/javascripts/explore/components/SaveModal_spec.jsx b/superset-frontend/spec/javascripts/explore/components/SaveModal_spec.jsx index 55ea431bfcb..a04aff9d9c6 100644 --- a/superset-frontend/spec/javascripts/explore/components/SaveModal_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/components/SaveModal_spec.jsx @@ -145,10 +145,8 @@ describe('SaveModal', () => { sinon.stub(defaultProps.actions, 'saveSlice').callsFake(() => Promise.resolve({ - data: { - dashboard_url: 'http://localhost/mock_dashboard/', - slice: { slice_url: '/mock_slice/' }, - }, + dashboard_url: 'http://localhost/mock_dashboard/', + slice: { slice_url: '/mock_slice/' }, }), ); }); diff --git a/superset-frontend/src/explore/actions/saveModalActions.js b/superset-frontend/src/explore/actions/saveModalActions.js index 0a0bd9a9809..ef4c9f8cbca 100644 --- a/superset-frontend/src/explore/actions/saveModalActions.js +++ b/superset-frontend/src/explore/actions/saveModalActions.js @@ -73,7 +73,7 @@ export function saveSlice(formData, requestParams) { return SupersetClient.post({ url, postPayload: { form_data: formData } }) .then(response => { dispatch(saveSliceSuccess(response.json)); - return response; + return response.json; }) .catch(() => dispatch(saveSliceFailed())); }; diff --git a/superset-frontend/src/explore/components/SaveModal.tsx b/superset-frontend/src/explore/components/SaveModal.tsx index 7e975d5b15d..dab88f29257 100644 --- a/superset-frontend/src/explore/components/SaveModal.tsx +++ b/superset-frontend/src/explore/components/SaveModal.tsx @@ -131,7 +131,7 @@ class SaveModal extends React.Component { this.props.actions .saveSlice(this.props.form_data, sliceParams) - .then(({ data }: JsonObject) => { + .then((data: JsonObject) => { if (data.dashboard_id === null) { sessionStorage.removeItem(SK_DASHBOARD_ID); } else {