QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 09:04:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(explore): UX improvements for drag'n'dropping time column (#15740)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2021-07-18 19:52:34 +02:00
committed by GitHub
parent e9383e6d00
commit 4234031cba
6 changed files with 65 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
View File

@@ -157,11 +157,11 @@ export const DndMetricSelect = (props: any) => {
const canDrop = (item: DatasourcePanelDndItem) => {
const isMetricAlreadyInValues =
item.type === 'metric' ? value.includes(item.value.metric_name) : false;
return (props.multi || value.length === 0) && !isMetricAlreadyInValues;
return !isMetricAlreadyInValues;
};
const onNewMetric = (newMetric: Metric) => {
const newValue = [...value, newMetric];
const newValue = props.isMulti ? [...value, newMetric] : [newMetric];
setValue(newValue);
handleChange(newValue);
};