QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: increment statsd as warn (#23041)

Browse Source
This commit is contained in:
Elizabeth Thompson
2023-02-16 15:43:18 -08:00
committed by GitHub
parent 92b9c06e59
commit 434b445e31
5 changed files with 115 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/integration_tests/base_tests.py
View File

@@ -90,6 +90,8 @@ def post_assert_metric(
rv = client.post(uri, json=data)
if 200 <= rv.status_code < 400:
mock_method.assert_called_once_with("success", func_name)
elif 400 <= rv.status_code < 500:
mock_method.assert_called_once_with("warning", func_name)
else:
mock_method.assert_called_once_with("error", func_name)
return rv
@@ -455,6 +457,8 @@ class SupersetTestCase(TestCase):
rv = self.client.get(uri)
if 200 <= rv.status_code < 400:
mock_method.assert_called_once_with("success", func_name)
elif 400 <= rv.status_code < 500:
mock_method.assert_called_once_with("warning", func_name)
else:
mock_method.assert_called_once_with("error", func_name)
return rv
@@ -474,6 +478,8 @@ class SupersetTestCase(TestCase):
rv = self.client.delete(uri)
if 200 <= rv.status_code < 400:
mock_method.assert_called_once_with("success", func_name)
elif 400 <= rv.status_code < 500:
mock_method.assert_called_once_with("warning", func_name)
else:
mock_method.assert_called_once_with("error", func_name)
return rv
@@ -501,6 +507,8 @@ class SupersetTestCase(TestCase):
rv = self.client.put(uri, json=data)
if 200 <= rv.status_code < 400:
mock_method.assert_called_once_with("success", func_name)
elif 400 <= rv.status_code < 500:
mock_method.assert_called_once_with("warning", func_name)
else:
mock_method.assert_called_once_with("error", func_name)
return rv

61
tests/integration_tests/utils/decorators_tests.py
View File

@@ -1,61 +0,0 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from unittest.mock import call, Mock, patch
import pytest
from flask import current_app
from superset.utils import decorators
from tests.integration_tests.base_tests import SupersetTestCase
class UtilsDecoratorsTests(SupersetTestCase):
def test_debounce(self):
mock = Mock()
@decorators.debounce()
def myfunc(arg1: int, arg2: int, kwarg1: str = "abc", kwarg2: int = 2):
mock(arg1, kwarg1)
return arg1 + arg2 + kwarg2
# should be called only once when arguments don't change
myfunc(1, 1)
myfunc(1, 1)
result = myfunc(1, 1)
mock.assert_called_once_with(1, "abc")
self.assertEqual(result, 4)
# kwarg order shouldn't matter
myfunc(1, 0, kwarg2=2, kwarg1="haha")
result = myfunc(1, 0, kwarg1="haha", kwarg2=2)
mock.assert_has_calls([call(1, "abc"), call(1, "haha")])
self.assertEqual(result, 3)
def test_statsd_gauge(self):
@decorators.statsd_gauge("custom.prefix")
def my_func(fail: bool, *args, **kwargs):
if fail:
raise ValueError("Error")
return "OK"
with patch.object(current_app.config["STATS_LOGGER"], "gauge") as mock:
my_func(False, 1, 2)
mock.assert_called_once_with("custom.prefix.ok", 1)
with pytest.raises(ValueError):
my_func(True, 1, 2)
mock.assert_called_once_with("custom.prefix.error", 1)