mirror of
https://github.com/apache/superset.git
synced 2026-04-24 10:35:01 +00:00
fix: escape bind-like strings in virtual table query (#17111)
This commit is contained in:
@@ -80,6 +80,7 @@ from sqlalchemy import event, exc, select, Text
|
||||
from sqlalchemy.dialects.mysql import MEDIUMTEXT
|
||||
from sqlalchemy.engine import Connection, Engine
|
||||
from sqlalchemy.engine.reflection import Inspector
|
||||
from sqlalchemy.sql.elements import TextClause
|
||||
from sqlalchemy.sql.type_api import Variant
|
||||
from sqlalchemy.types import TEXT, TypeDecorator, TypeEngine
|
||||
from typing_extensions import TypedDict, TypeGuard
|
||||
@@ -131,6 +132,8 @@ JS_MAX_INTEGER = 9007199254740991 # Largest int Java Script can handle 2^53-1
|
||||
|
||||
InputType = TypeVar("InputType")
|
||||
|
||||
BIND_PARAM_REGEX = TextClause._bind_params_regex # pylint: disable=protected-access
|
||||
|
||||
|
||||
class LenientEnum(Enum):
|
||||
"""Enums with a `get` method that convert a enum value to `Enum` if it is a
|
||||
@@ -1784,3 +1787,29 @@ def apply_max_row_limit(limit: int, max_limit: Optional[int] = None,) -> int:
|
||||
if limit != 0:
|
||||
return min(max_limit, limit)
|
||||
return max_limit
|
||||
|
||||
|
||||
def escape_sqla_query_binds(sql: str) -> str:
|
||||
"""
|
||||
Replace strings in a query that SQLAlchemy would otherwise interpret as
|
||||
bind parameters.
|
||||
|
||||
:param sql: unescaped query string
|
||||
:return: escaped query string
|
||||
>>> escape_sqla_query_binds("select ':foo'")
|
||||
"select '\\\\:foo'"
|
||||
>>> escape_sqla_query_binds("select 'foo'::TIMESTAMP")
|
||||
"select 'foo'::TIMESTAMP"
|
||||
>>> escape_sqla_query_binds("select ':foo :bar'::TIMESTAMP")
|
||||
"select '\\\\:foo \\\\:bar'::TIMESTAMP"
|
||||
>>> escape_sqla_query_binds("select ':foo :foo :bar'::TIMESTAMP")
|
||||
"select '\\\\:foo \\\\:foo \\\\:bar'::TIMESTAMP"
|
||||
"""
|
||||
matches = BIND_PARAM_REGEX.finditer(sql)
|
||||
processed_binds = set()
|
||||
for match in matches:
|
||||
bind = match.group(0)
|
||||
if bind not in processed_binds:
|
||||
sql = sql.replace(bind, bind.replace(":", "\\:"))
|
||||
processed_binds.add(bind)
|
||||
return sql
|
||||
|
||||
Reference in New Issue
Block a user