QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab_export): manually encode CSV output to support utf-8-sig (#34235)

Browse Source
This commit is contained in:
Ahmed Habeeb
2025-07-24 04:44:56 +03:00
committed by GitHub
parent 9099b0f00d
commit 43775e9373
6 changed files with 42 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/integration_tests/sql_lab/commands_tests.py
View File

@@ -177,7 +177,7 @@ class TestSqlResultExportCommand(SupersetTestCase):
get_df_mock.return_value = pd.DataFrame({"foo": [1, 2, 3]})
result = command.run()
assert result["data"] == "foo\n1\n2\n3\n"
assert result["data"] == b"\xef\xbb\xbffoo\n1\n2\n3\n"
assert result["count"] == 3
assert result["query"].client_id == "test"
@@ -195,7 +195,7 @@ class TestSqlResultExportCommand(SupersetTestCase):
get_df_mock.return_value = pd.DataFrame({"foo": [1, 2, 3]})
result = command.run()
assert result["data"] == "foo\n1\n2\n"
assert result["data"] == b"\xef\xbb\xbffoo\n1\n2\n"
assert result["count"] == 2
assert result["query"].client_id == "test"
@@ -217,7 +217,7 @@ class TestSqlResultExportCommand(SupersetTestCase):
result = command.run()
assert result["data"] == "foo\n1\n"
assert result["data"] == b"\xef\xbb\xbffoo\n1\n"
assert result["count"] == 1
assert result["query"].client_id == "test"
@@ -240,7 +240,7 @@ class TestSqlResultExportCommand(SupersetTestCase):
result = command.run()
assert result["data"] == "foo\n0\n1\n2\n3\n4\n"
assert result["data"] == b"\xef\xbb\xbffoo\n0\n1\n2\n3\n4\n"
assert result["count"] == 5
assert result["query"].client_id == "test"