From 439130db545d275cb5e4406d423dfa8a644f12db Mon Sep 17 00:00:00 2001 From: Beto Dealmeida Date: Tue, 12 May 2026 09:59:55 -0400 Subject: [PATCH] Add dialects for Exa/Solr --- superset/db_engine_specs/exasol.py | 2 -- superset/db_engine_specs/solr.py | 2 +- superset/sql/parse.py | 4 ++-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/superset/db_engine_specs/exasol.py b/superset/db_engine_specs/exasol.py index 16776194d7d..bd83a5d34f0 100644 --- a/superset/db_engine_specs/exasol.py +++ b/superset/db_engine_specs/exasol.py @@ -18,7 +18,6 @@ from typing import Any, Optional from superset.constants import TimeGrain from superset.db_engine_specs.base import BaseEngineSpec, DatabaseCategory -from superset.sql.parse import RLSMethod class ExasolEngineSpec(BaseEngineSpec): # pylint: disable=abstract-method @@ -27,7 +26,6 @@ class ExasolEngineSpec(BaseEngineSpec): # pylint: disable=abstract-method engine = "exa" engine_name = "Exasol" max_column_name_length = 128 - rls_method = RLSMethod.AS_PREDICATE_SPLICE metadata = { "description": ( diff --git a/superset/db_engine_specs/solr.py b/superset/db_engine_specs/solr.py index 2f677b07132..4f08e94ecac 100644 --- a/superset/db_engine_specs/solr.py +++ b/superset/db_engine_specs/solr.py @@ -28,7 +28,7 @@ class SolrEngineSpec(BaseEngineSpec): # pylint: disable=abstract-method time_groupby_inline = False allows_joins = False allows_subqueries = False - rls_method = RLSMethod.AS_PREDICATE_SPLICE + rls_method = RLSMethod.AS_PREDICATE metadata = { "description": "Apache Solr is an open-source enterprise search platform.", diff --git a/superset/sql/parse.py b/superset/sql/parse.py index db84bb2dc7b..7fb2c8a3f97 100644 --- a/superset/sql/parse.py +++ b/superset/sql/parse.py @@ -76,7 +76,7 @@ SQLGLOT_DIALECTS = { "duckdb": Dialects.DUCKDB, # "dynamodb": ??? # "elasticsearch": ??? - # "exa": ??? + "exa": Dialects.EXASOL, # "firebird": ??? "firebolt": Firebolt, "gsheets": Dialects.SQLITE, @@ -105,7 +105,7 @@ SQLGLOT_DIALECTS = { "shillelagh": Dialects.SQLITE, "singlestoredb": SingleStore, "snowflake": Dialects.SNOWFLAKE, - # "solr": ??? + "solr": Dialects.SOLR, "spark": Dialects.SPARK, "sqlite": Dialects.SQLITE, "starrocks": Dialects.STARROCKS,