QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Refactor SQL username logic (#19914)

Browse Source 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley
2022-05-12 21:03:05 -07:00
committed by GitHub
parent fff9ad05d4
commit 449d08b25e
22 changed files with 388 additions and 340 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration_tests/base_tests.py
View File

@@ -329,7 +329,7 @@ class SupersetTestCase(TestCase):
self,
sql,
client_id=None,
user_name=None,
username=None,
raise_on_error=False,
query_limit=None,
database_name="examples",
@@ -340,9 +340,9 @@ class SupersetTestCase(TestCase):
ctas_method=CtasMethod.TABLE,
template_params="{}",
):
if user_name:
if username:
self.logout()
self.login(username=(user_name or "admin"))
self.login(username=username)
dbid = SupersetTestCase.get_database_by_name(database_name).id
json_payload = {
"database_id": dbid,
@@ -427,14 +427,14 @@ class SupersetTestCase(TestCase):
self,
sql,
client_id=None,
user_name=None,
username=None,
raise_on_error=False,
database_name="examples",
template_params=None,
):
if user_name:
if username:
self.logout()
self.login(username=(user_name if user_name else "admin"))
self.login(username=username)
dbid = SupersetTestCase.get_database_by_name(database_name).id
resp = self.get_json_resp(
"/superset/validate_sql_json/",