QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-11 17:25:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): dispatch onChange immediately on NumberControl stepper arrow clicks (#39220)

Browse Source 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Abdul Rehman
2026-04-15 22:15:37 +05:00
committed by GitHub
parent 18d6feb499
commit 44e77fdf2b
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/src/explore/components/controls/NumberControl/NumberControl.test.tsx
View File

@@ -82,6 +82,21 @@ test('can clear field completely', async () => {
expect(props.onChange).toHaveBeenLastCalledWith(undefined);
});
test('stepper arrows trigger onChange immediately', async () => {
const props = {
...mockedProps,
value: 5,
onChange: jest.fn(),
};
render(<NumberControl {...props} />);
const upButton = document.querySelector(
'.ant-input-number-handler-up',
) as HTMLElement;
expect(upButton).toBeInTheDocument();
await userEvent.click(upButton);
expect(props.onChange).toHaveBeenCalledWith(6);
});
test('updates local value when prop changes', () => {
const props = {
...mockedProps,