QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: make sure to quote formulas on Excel export (#31166)

Browse Source
This commit is contained in:
Beto Dealmeida
2024-11-26 18:16:44 -05:00
committed by GitHub
parent 529aed5da1
commit 45668e31fc
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/unit_tests/utils/excel_tests.py
View File

@@ -34,6 +34,19 @@ def test_timezone_conversion() -> None:
assert pd.read_excel(contents)["dt"][0] == "2023-01-01 00:00:00+00:00"
def test_quote_formulas() -> None:
"""
Test that formulas are quoted in Excel.
"""
df = pd.DataFrame({"formula": ["=SUM(A1:A2)", "normal", "@SUM(A1:A2)"]})
contents = df_to_excel(df)
assert pd.read_excel(contents)["formula"].tolist() == [
"'=SUM(A1:A2)",
"normal",
"'@SUM(A1:A2)",
]
def test_column_data_types_with_one_numeric_column():
df = pd.DataFrame(
{