diff --git a/superset-frontend/src/components/EditableTitle/EditableTitle.stories.tsx b/superset-frontend/src/components/EditableTitle/EditableTitle.stories.tsx new file mode 100644 index 00000000000..de7cbb94f3f --- /dev/null +++ b/superset-frontend/src/components/EditableTitle/EditableTitle.stories.tsx @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import EditableTitle, { EditableTitleProps } from '.'; + +export default { + title: 'EditableTitle', + component: EditableTitle, +}; + +export const InteractiveEditableTitle = (props: EditableTitleProps) => ( + +); + +InteractiveEditableTitle.args = { + canEdit: true, + editing: false, + emptyText: 'Empty text', + multiLine: true, + noPermitTooltip: 'Not permitted', + showTooltip: true, + title: 'Title', + defaultTitle: 'Default title', + placeholder: 'Placeholder', +}; + +InteractiveEditableTitle.argTypes = { + onSaveTitle: { action: 'onSaveTitle' }, +}; + +InteractiveEditableTitle.story = { + parameters: { + knobs: { + disable: true, + }, + }, +}; diff --git a/superset-frontend/spec/javascripts/profile/EditableTitle_spec.tsx b/superset-frontend/src/components/EditableTitle/EditableTitle.test.tsx similarity index 100% rename from superset-frontend/spec/javascripts/profile/EditableTitle_spec.tsx rename to superset-frontend/src/components/EditableTitle/EditableTitle.test.tsx diff --git a/superset-frontend/src/components/EditableTitle.tsx b/superset-frontend/src/components/EditableTitle/index.tsx similarity index 98% rename from superset-frontend/src/components/EditableTitle.tsx rename to superset-frontend/src/components/EditableTitle/index.tsx index 3a35370095c..5d407d20376 100644 --- a/superset-frontend/src/components/EditableTitle.tsx +++ b/superset-frontend/src/components/EditableTitle/index.tsx @@ -21,14 +21,14 @@ import cx from 'classnames'; import { t } from '@superset-ui/core'; import { Tooltip } from 'src/common/components/Tooltip'; -interface EditableTitleProps { +export interface EditableTitleProps { canEdit?: boolean; editing?: boolean; emptyText?: string; extraClasses?: Array | string; multiLine?: boolean; noPermitTooltip?: string; - onSaveTitle: (arg0: string) => {}; + onSaveTitle: (arg0: string) => void; showTooltip?: boolean; style?: object; title?: string;