QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Redirect on 401 (#17597)

Browse Source 
* Redirect on 401

* Bump FAB

* Format

* Update Cypress save test

* Revert Cypress change

* Bump FAB 3.4.1rc2

* Update test

* Update return statement

* Update api test

* Update datasets api test

* Update datasets api 401s to 403s

* Add typeguard

* Use Promise.resolve

* Update callApiAndParseWithhTimeout test

* Disable parseResponse test

* Try catch

* Handle npm 8 issues
This commit is contained in:
Geido
2021-12-08 22:14:30 +02:00
committed by GitHub
parent aee5c9a3ea
commit 46cdc77ae6
13 changed files with 73 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration_tests/datasets/api_tests.py
View File

@@ -432,7 +432,7 @@ class TestDatasetApi(SupersetTestCase):
}
uri = "api/v1/dataset/"
rv = self.client.post(uri, json=table_data)
assert rv.status_code == 401
assert rv.status_code == 403
def test_create_dataset_item_owner(self):
"""
@@ -986,7 +986,7 @@ class TestDatasetApi(SupersetTestCase):
table_data = {"description": "changed_description"}
uri = f"api/v1/dataset/{dataset.id}"
rv = self.client.put(uri, json=table_data)
assert rv.status_code == 401
assert rv.status_code == 403
db.session.delete(dataset)
db.session.commit()
@@ -1094,7 +1094,7 @@ class TestDatasetApi(SupersetTestCase):
self.login(username="gamma")
uri = f"api/v1/dataset/{dataset.id}"
rv = self.client.delete(uri)
assert rv.status_code == 401
assert rv.status_code == 403
db.session.delete(dataset)
db.session.commit()
@@ -1313,7 +1313,7 @@ class TestDatasetApi(SupersetTestCase):
self.login(username="gamma")
uri = f"api/v1/dataset/?q={prison.dumps(dataset_ids)}"
rv = self.client.delete(uri)
assert rv.status_code == 401
assert rv.status_code == 403
@pytest.mark.usefixtures("create_datasets")
def test_bulk_delete_dataset_item_incorrect(self):
@@ -1438,7 +1438,7 @@ class TestDatasetApi(SupersetTestCase):
self.login(username="gamma")
rv = self.client.get(uri)
assert rv.status_code == 401
assert rv.status_code == 403
perm1 = security_manager.find_permission_view_menu("can_export", "Dataset")
@@ -1516,7 +1516,7 @@ class TestDatasetApi(SupersetTestCase):
self.login(username="gamma")
rv = self.client.get(uri)
# gamma users by default do not have access to this dataset
assert rv.status_code == 401
assert rv.status_code == 403
@unittest.skip("Number of related objects depend on DB")
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")