QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 09:04:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explorev2] adding support for client side validators on controls (#1920)

Browse Source 
* Adding support for client side validators on controls

* Applying validators to more fields

* Addressing comments
This commit is contained in:
Maxime Beauchemin
2017-01-12 09:21:17 -08:00
committed by GitHub
parent fc74fbeeaa
commit 470a6e9d76
20 changed files with 237 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/spec/javascripts/explorev2/components/CheckboxField_spec.js
View File

@@ -26,6 +26,6 @@ describe('CheckboxField', () => {
it('calls onChange when toggled', () => {
const checkbox = wrapper.find(Checkbox);
checkbox.simulate('change', { value: true });
expect(defaultProps.onChange.calledWith('show_legend')).to.be.true;
expect(defaultProps.onChange.calledWith(true)).to.be.true;
});
});

5
superset/assets/spec/javascripts/explorev2/components/ControlPanelsContainer_spec.js
View File

@@ -3,16 +3,19 @@ import { expect } from 'chai';
import { describe, it, beforeEach } from 'mocha';
import { shallow } from 'enzyme';
import { Panel } from 'react-bootstrap';
import { defaultFormData } from '../../../../javascripts/explorev2/stores/store';
import { defaultFormData, initialState } from '../../../../javascripts/explorev2/stores/store';
import {
ControlPanelsContainer,
} from '../../../../javascripts/explorev2/components/ControlPanelsContainer';
import { fields } from '../../../../javascripts/explorev2/stores/fields';
const defaultProps = {
datasource_id: 1,
datasource_type: 'type',
exploreState: initialState(),
form_data: defaultFormData(),
fields,
actions: {
fetchFieldOptions: () => {
// noop

2
superset/assets/spec/javascripts/explorev2/components/SelectField_spec.js
View File

@@ -28,7 +28,7 @@ describe('SelectField', () => {
it('calls onChange when toggled', () => {
const select = wrapper.find(Select);
select.simulate('change', { value: 50 });
expect(defaultProps.onChange.calledWith('row_limit', 50)).to.be.true;
expect(defaultProps.onChange.calledWith(50)).to.be.true;
});
it('renders a Creatable for freeform', () => {

2
superset/assets/spec/javascripts/explorev2/components/TextArea_spec.js
View File

@@ -27,6 +27,6 @@ describe('SelectField', () => {
it('calls onChange when toggled', () => {
const select = wrapper.find(FormControl);
select.simulate('change', { target: { value: 'x' } });
expect(defaultProps.onChange.calledWith('x_axis_label', 'x')).to.be.true;
expect(defaultProps.onChange.calledWith('x')).to.be.true;
});
});