QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: excel sheet upload is not working (#10450)

Browse Source 
* remove conflicts with csv upload

* revert StringField

* change description

* remove redundant space

* apply string approach
This commit is contained in:
pphszx
2020-07-29 15:20:44 +08:00
committed by GitHub
parent c716f7afe8
commit 473fe1003a
3 changed files with 35 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
superset/db_engine_specs/base.py
View File

@@ -438,10 +438,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
"""
kwargs["encoding"] = "utf-8"
kwargs["iterator"] = True
chunks = pd.io.excel.read_excel(
io=kwargs["filepath_or_buffer"], sheet_name=kwargs["sheet_name"]
)
df = pd.concat(chunk for chunk in chunks.values())
df = pd.read_excel(**kwargs)
return df
@staticmethod
@@ -513,7 +510,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
Create table from contents of a excel. Note: this method does not create
metadata for the table.
"""
df = cls.excel_to_df(filepath_or_buffer=filename, **excel_to_df_kwargs,)
df = cls.excel_to_df(io=filename, **excel_to_df_kwargs,)
engine = cls.get_engine(database)
if table.schema:
# only add schema when it is preset and non empty