QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

ESLint: Re-enable rule no-access-state-in-setstate (#10870)

Browse Source 
* Re-enable rule no-access-state-in-setstate

* Move accessing event values out of async functions
This commit is contained in:
Kamil Gabryjelski
2020-09-21 08:48:23 +02:00
committed by GitHub
parent 3d8f757ac8
commit 4835d3b0a2
25 changed files with 83 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/src/datasource/DatasourceEditor.jsx
View File

@@ -289,7 +289,10 @@ class DatasourceEditor extends React.PureComponent {
onDatasourcePropChange(attr, value) {
const datasource = { ...this.state.datasource, [attr]: value };
this.setState({ datasource }, this.onDatasourceChange(datasource));
this.setState(
prevState => ({ datasource: { ...prevState.datasource, [attr]: value } }),
this.onDatasourceChange(datasource),
);
}
setColumns(obj) {