QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

ESLint: Re-enable rule no-access-state-in-setstate (#10870)

Browse Source 
* Re-enable rule no-access-state-in-setstate

* Move accessing event values out of async functions
This commit is contained in:
Kamil Gabryjelski
2020-09-21 08:48:23 +02:00
committed by GitHub
parent 3d8f757ac8
commit 4835d3b0a2
25 changed files with 83 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx
View File

@@ -88,40 +88,41 @@ export default class AdhocMetricEditPopover extends React.Component {
}
onColumnChange(column) {
this.setState({
adhocMetric: this.state.adhocMetric.duplicateWith({
this.setState(prevState => ({
adhocMetric: prevState.adhocMetric.duplicateWith({
column,
expressionType: EXPRESSION_TYPES.SIMPLE,
}),
});
}));
}
onAggregateChange(aggregate) {
// we construct this object explicitly to overwrite the value in the case aggregate is null
this.setState({
adhocMetric: this.state.adhocMetric.duplicateWith({
this.setState(prevState => ({
adhocMetric: prevState.adhocMetric.duplicateWith({
aggregate,
expressionType: EXPRESSION_TYPES.SIMPLE,
}),
});
}));
}
onSqlExpressionChange(sqlExpression) {
this.setState({
adhocMetric: this.state.adhocMetric.duplicateWith({
this.setState(prevState => ({
adhocMetric: prevState.adhocMetric.duplicateWith({
sqlExpression,
expressionType: EXPRESSION_TYPES.SQL,
}),
});
}));
}
onLabelChange(e) {
this.setState({
adhocMetric: this.state.adhocMetric.duplicateWith({
label: e.target.value,
const label = e.target.value;
this.setState(prevState => ({
adhocMetric: prevState.adhocMetric.duplicateWith({
label,
hasCustomLabel: true,
}),
});
}));
}
onDragDown(e) {

2
superset-frontend/src/explore/components/ControlPanelSection.jsx
View File

@@ -44,7 +44,7 @@ export default class ControlPanelSection extends React.Component {
}
toggleExpand() {
this.setState({ expanded: !this.state.expanded });
this.setState(prevState => ({ expanded: !prevState.expanded }));
}
renderHeader() {

2
superset-frontend/src/explore/components/ExploreViewContainer.jsx
View File

@@ -281,7 +281,7 @@ class ExploreViewContainer extends React.Component {
}
toggleModal() {
this.setState({ showModal: !this.state.showModal });
this.setState(prevState => ({ showModal: !prevState.showModal }));
}
hasErrors() {

2
superset-frontend/src/explore/components/controls/AnnotationLayer.jsx
View File

@@ -333,7 +333,7 @@ export default class AnnotationLayer extends React.PureComponent {
annotation.color =
annotation.color === AUTOMATIC_COLOR ? null : annotation.color;
this.props.addAnnotationLayer(annotation);
this.setState({ isNew: false, oldName: this.state.name });
this.setState(prevState => ({ isNew: false, oldName: prevState.name }));
}
}

14
superset-frontend/src/explore/components/controls/BoundsControl.jsx
View File

@@ -47,19 +47,21 @@ export default class BoundsControl extends React.Component {
}
onMinChange(event) {
const min = event.target.value;
this.setState(
{
minMax: [event.target.value, this.state.minMax[1]],
},
prevState => ({
minMax: [min, prevState.minMax[1]],
}),
this.onChange,
);
}
onMaxChange(event) {
const max = event.target.value;
this.setState(
{
minMax: [this.state.minMax[0], event.target.value],
},
prevState => ({
minMax: [prevState.minMax[0], max],
}),
this.onChange,
);
}

12
superset-frontend/src/explore/components/controls/DateFilterControl.jsx
View File

@@ -259,14 +259,14 @@ class DateFilterControl extends React.Component {
const closeCalendar =
(key === 'since' && this.state.sinceViewMode === 'days') ||
(key === 'until' && this.state.untilViewMode === 'days');
this.setState({
this.setState(prevState => ({
type: TYPES.CUSTOM_START_END,
[key]: typeof value === 'string' ? value : value.format(MOMENT_FORMAT),
showSinceCalendar: this.state.showSinceCalendar && !closeCalendar,
showUntilCalendar: this.state.showUntilCalendar && !closeCalendar,
sinceViewMode: closeCalendar ? 'days' : this.state.sinceViewMode,
untilViewMode: closeCalendar ? 'days' : this.state.untilViewMode,
});
showSinceCalendar: prevState.showSinceCalendar && !closeCalendar,
showUntilCalendar: prevState.showUntilCalendar && !closeCalendar,
sinceViewMode: closeCalendar ? 'days' : prevState.sinceViewMode,
untilViewMode: closeCalendar ? 'days' : prevState.untilViewMode,
}));
}
setTypeCustomRange() {

7
superset-frontend/src/explore/components/controls/FixedOrMetricControl.jsx
View File

@@ -90,10 +90,9 @@ export default class FixedOrMetricControl extends React.Component {
}
toggle() {
const expanded = !this.state.expanded;
this.setState({
expanded,
});
this.setState(prevState => ({
expanded: !prevState.expanded,
}));
}
render() {

2
superset-frontend/src/explore/components/controls/SpatialControl.jsx
View File

@@ -114,7 +114,7 @@ export default class SpatialControl extends React.Component {
toggleCheckbox() {
this.setState(
{ reverseCheckbox: !this.state.reverseCheckbox },
prevState => ({ reverseCheckbox: !prevState.reverseCheckbox }),
this.onChange,
);
}

2
superset-frontend/src/explore/components/controls/VizTypeControl.jsx
View File

@@ -120,7 +120,7 @@ export default class VizTypeControl extends React.PureComponent {
}
toggleModal() {
this.setState({ showModal: !this.state.showModal });
this.setState(prevState => ({ showModal: !prevState.showModal }));
}
changeSearch(event) {