QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Improve state key generation for dashboards and charts (#18576)

Browse Source 
* feat: Improve state key generation for dashboards and charts
This commit is contained in:
Michael S. Molina
2022-02-14 17:09:06 -03:00
committed by GitHub
parent 801091be03
commit 48a80950de
29 changed files with 694 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx
View File

@@ -24,7 +24,7 @@ import { connect } from 'react-redux';
import { styled, t, css, useTheme, logging } from '@superset-ui/core';
import { debounce } from 'lodash';
import { Resizable } from 're-resizable';
import { useChangeEffect } from 'src/hooks/useChangeEffect';
import { usePluginContext } from 'src/components/DynamicPlugins';
import { Global } from '@emotion/react';
import { Tooltip } from 'src/components/Tooltip';
@@ -44,6 +44,7 @@ import { fetchDatasourceMetadata } from 'src/dashboard/actions/datasources';
import { chartPropShape } from 'src/dashboard/util/propShapes';
import { mergeExtraFormData } from 'src/dashboard/components/nativeFilters/utils';
import { postFormData, putFormData } from 'src/explore/exploreUtils/formData';
import { useTabId } from 'src/hooks/useTabId';
import ExploreChartPanel from '../ExploreChartPanel';
import ConnectedControlPanelsContainer from '../ControlPanelsContainer';
import SaveModal from '../SaveModal';
@@ -164,7 +165,7 @@ function useWindowSize({ delayMs = 250 } = {}) {
}
const updateHistory = debounce(
async (formData, datasetId, isReplace, standalone, force, title) => {
async (formData, datasetId, isReplace, standalone, force, title, tabId) => {
const payload = { ...formData };
const chartId = formData.slice_id;
const additionalParam = {};
@@ -178,11 +179,11 @@ const updateHistory = debounce(
let key;
let stateModifier;
if (isReplace) {
key = await postFormData(datasetId, formData, chartId);
key = await postFormData(datasetId, formData, chartId, tabId);
stateModifier = 'replaceState';
} else {
key = getUrlParam(URL_PARAMS.formDataKey);
await putFormData(datasetId, key, formData, chartId);
await putFormData(datasetId, key, formData, chartId, tabId);
stateModifier = 'pushState';
}
const url = mountExploreUrl(
@@ -218,6 +219,7 @@ function ExploreViewContainer(props) {
const [showingModal, setShowingModal] = useState(false);
const [isCollapsed, setIsCollapsed] = useState(false);
const [shouldForceUpdate, setShouldForceUpdate] = useState(-1);
const tabId = useTabId();
const theme = useTheme();
const width = `${windowSize.width}px`;
@@ -248,6 +250,7 @@ function ExploreViewContainer(props) {
props.standalone,
props.force,
title,
tabId,
);
},
[
@@ -256,6 +259,7 @@ function ExploreViewContainer(props) {
props.datasource.id,
props.standalone,
props.force,
tabId,
],
);
@@ -322,7 +326,12 @@ function ExploreViewContainer(props) {
useComponentDidMount(() => {
props.actions.logEvent(LOG_ACTIONS_MOUNT_EXPLORER);
addHistory({ isReplace: true });
});
useChangeEffect(tabId, (previous, current) => {
if (current) {
addHistory({ isReplace: true });
}
});
const previousHandlePopstate = usePrevious(handlePopstate);