chore: deprecate pylint in favor of ruff (#31262)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
This commit is contained in:
Maxime Beauchemin
2024-12-13 12:53:14 -08:00
committed by GitHub
parent 21e794a66f
commit 4bccf36375
8 changed files with 22 additions and 455 deletions

View File

@@ -478,37 +478,7 @@ A series of checks will now run when you make a git commit.
## Linting
### Python
We use [Pylint](https://pylint.org/) for linting which can be invoked via:
```bash
pylint
```
In terms of best practices please avoid blanket disabling of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disabling should occur inline as it prevents masking issues and provides context as to why said message is disabled.
Additionally, the Python code is auto-formatted using [Black](https://github.com/python/black) which
is configured as a pre-commit hook. There are also numerous [editor integrations](https://black.readthedocs.io/en/stable/integrations/editors.html)
### TypeScript
```bash
cd superset-frontend
npm ci
# run eslint checks
npm run eslint -- .
# run tsc (typescript) checks
npm run type
```
If using the eslint extension with vscode, put the following in your workspace `settings.json` file:
```json
"eslint.workingDirectories": [
"superset-frontend"
]
```
See [how tos](/docs/contributing/howtos#linting)
## GitHub Actions and `act`