QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(alerts): restrict list view and gamma perms (#21765)

Browse Source
This commit is contained in:
Ville Brofeldt
2022-10-15 10:03:26 +03:00
committed by GitHub
parent 196c3671e2
commit 4c1777f20d
10 changed files with 221 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

154
tests/integration_tests/reports/api_tests.py
View File

@@ -23,9 +23,10 @@ import pytz
import pytest
import prison
from parameterized import parameterized
from sqlalchemy.sql import func
from superset import db
from superset import db, security_manager
from superset.models.core import Database
from superset.models.slice import Slice
from superset.models.dashboard import Dashboard
@@ -48,11 +49,95 @@ from tests.integration_tests.fixtures.birth_names_dashboard import (
from tests.integration_tests.reports.utils import insert_report_schedule
REPORTS_COUNT = 10
REPORTS_ROLE_NAME = "reports_role"
REPORTS_GAMMA_USER = "reports_gamma"
class TestReportSchedulesApi(SupersetTestCase):
@pytest.fixture()
def create_working_report_schedule(self):
def gamma_user_with_alerts_role(self):
with self.create_app().app_context():
user = self.create_user(
REPORTS_GAMMA_USER,
"general",
"Gamma",
email=f"{REPORTS_GAMMA_USER}@superset.org",
)
security_manager.add_role(REPORTS_ROLE_NAME)
read_perm = security_manager.find_permission_view_menu(
"can_read",
"ReportSchedule",
)
write_perm = security_manager.find_permission_view_menu(
"can_write",
"ReportSchedule",
)
reports_role = security_manager.find_role(REPORTS_ROLE_NAME)
security_manager.add_permission_role(reports_role, read_perm)
security_manager.add_permission_role(reports_role, write_perm)
user.roles.append(reports_role)
yield user
# rollback changes (assuming cascade delete)
db.session.delete(reports_role)
db.session.delete(user)
db.session.commit()
@pytest.fixture()
def create_working_admin_report_schedule(self):
with self.create_app().app_context():
admin_user = self.get_user("admin")
chart = db.session.query(Slice).first()
example_db = get_example_database()
report_schedule = insert_report_schedule(
type=ReportScheduleType.ALERT,
name="name_admin_working",
crontab="* * * * *",
sql="SELECT value from table",
description="Report working",
chart=chart,
database=example_db,
owners=[admin_user],
last_state=ReportState.WORKING,
)
yield
db.session.delete(report_schedule)
db.session.commit()
@pytest.mark.usefixtures("gamma_user_with_alerts_role")
@pytest.fixture()
def create_working_gamma_report_schedule(self, gamma_user_with_alerts_role):
with self.create_app().app_context():
chart = db.session.query(Slice).first()
example_db = get_example_database()
report_schedule = insert_report_schedule(
type=ReportScheduleType.ALERT,
name="name_gamma_working",
crontab="* * * * *",
sql="SELECT value from table",
description="Report working",
chart=chart,
database=example_db,
owners=[gamma_user_with_alerts_role],
last_state=ReportState.WORKING,
)
yield
db.session.delete(report_schedule)
db.session.commit()
@pytest.mark.usefixtures("gamma_user_with_alerts_role")
@pytest.fixture()
def create_working_shared_report_schedule(self, gamma_user_with_alerts_role):
with self.create_app().app_context():
admin_user = self.get_user("admin")
@@ -62,13 +147,13 @@ class TestReportSchedulesApi(SupersetTestCase):
report_schedule = insert_report_schedule(
type=ReportScheduleType.ALERT,
name="name_working",
name="name_shared_working",
crontab="* * * * *",
sql="SELECT value from table",
description="Report working",
chart=chart,
database=example_db,
owners=[admin_user, alpha_user],
owners=[admin_user, alpha_user, gamma_user_with_alerts_role],
last_state=ReportState.WORKING,
)
@@ -305,6 +390,61 @@ class TestReportSchedulesApi(SupersetTestCase):
data_keys = sorted(list(data["result"][1]["recipients"][0].keys()))
assert expected_recipients_fields == data_keys
@parameterized.expand(
[
(
"admin",
{
"name_admin_working",
"name_gamma_working",
"name_shared_working",
},
),
(
"alpha",
{
"name_admin_working",
"name_gamma_working",
"name_shared_working",
},
),
(
REPORTS_GAMMA_USER,
{
"name_gamma_working",
"name_shared_working",
},
),
],
)
@pytest.mark.usefixtures(
"create_working_admin_report_schedule",
"create_working_gamma_report_schedule",
"create_working_shared_report_schedule",
"gamma_user_with_alerts_role",
)
def test_get_list_report_schedule_perms(self, username, report_names):
"""
ReportSchedule Api: Test get list report schedules for different roles
"""
self.login(username=username)
uri = f"api/v1/report/"
rv = self.get_assert_metric(uri, "get_list")
assert rv.status_code == 200
data = json.loads(rv.data.decode("utf-8"))
assert {report["name"] for report in data["result"]} == report_names
def test_get_list_report_schedule_gamma(self):
"""
ReportSchedule Api: Test get list report schedules for regular gamma user
"""
self.login(username="gamma")
uri = f"api/v1/report/"
rv = self.client.get(uri)
assert rv.status_code == 403
@pytest.mark.usefixtures("create_report_schedules")
def test_get_list_report_schedule_sorting(self):
"""
@@ -1159,14 +1299,14 @@ class TestReportSchedulesApi(SupersetTestCase):
assert updated_model.chart_id == report_schedule_data["chart"]
assert updated_model.database_id == report_schedule_data["database"]
@pytest.mark.usefixtures("create_working_report_schedule")
@pytest.mark.usefixtures("create_working_shared_report_schedule")
def test_update_report_schedule_state_working(self):
"""
ReportSchedule Api: Test update state in a working report
"""
report_schedule = (
db.session.query(ReportSchedule)
.filter(ReportSchedule.name == "name_working")
.filter(ReportSchedule.name == "name_shared_working")
.one_or_none()
)
@@ -1177,7 +1317,7 @@ class TestReportSchedulesApi(SupersetTestCase):
assert rv.status_code == 200
report_schedule = (
db.session.query(ReportSchedule)
.filter(ReportSchedule.name == "name_working")
.filter(ReportSchedule.name == "name_shared_working")
.one_or_none()
)
assert report_schedule.last_state == ReportState.NOOP