QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 23:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explore] include ControlHeader as part of Control interface (#2809)

Browse Source 
* [explore] include ControlHeader as part of Control interface

* Adressing comments
This commit is contained in:
Maxime Beauchemin
2017-05-25 11:54:26 -07:00
committed by GitHub
parent 0c9f9b695b
commit 4d12251806
9 changed files with 51 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset/assets/javascripts/explore/components/Control.jsx
View File

@@ -1,6 +1,5 @@
import React from 'react';
import PropTypes from 'prop-types';
import ControlHeader from './ControlHeader';
import CheckboxControl from './controls/CheckboxControl';
import FilterControl from './controls/FilterControl';
@@ -90,13 +89,6 @@ export default class Control extends React.PureComponent {
const divStyle = this.props.hidden ? { display: 'none' } : null;
return (
<div style={divStyle}>
<ControlHeader
label={this.props.label}
description={this.props.description}
renderTrigger={this.props.renderTrigger}
validationErrors={this.props.validationErrors}
rightNode={this.props.rightNode}
/>
<ControlType
onChange={this.onChange}
{...this.props}