From 4e3102935cc10e4a3f407f0e351eb88a2e0bdae0 Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Thu, 28 Oct 2021 08:44:30 -0700 Subject: [PATCH] fix: revert default series limit and update eligible choices (#1430) * Revert "feat: add default series_limit (#1033)" This reverts commit 5bd2a149644e9ecfeca8e54153eb9e5658546ec3. * Update index.tsx * Update index.tsx --- .../superset-ui-chart-controls/src/shared-controls/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/index.tsx b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/index.tsx index a338a054df2..3de5c19e9fa 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/index.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/index.tsx @@ -87,7 +87,7 @@ const sequentialSchemeRegistry = getSequentialSchemeRegistry(); export const PRIMARY_COLOR = { r: 0, g: 122, b: 135, a: 1 }; const ROW_LIMIT_OPTIONS = [10, 50, 100, 250, 500, 1000, 5000, 10000, 50000]; -const SERIES_LIMITS = [0, 5, 10, 25, 50, 100, 500]; +const SERIES_LIMITS = [5, 10, 25, 50, 100, 500]; type Control = { savedMetrics?: Metric[] | null; @@ -331,8 +331,8 @@ const limit: SharedControlConfig<'SelectControl'> = { freeForm: true, label: t('Series limit'), validators: [legacyValidateInteger], - default: 100, choices: formatSelectOptions(SERIES_LIMITS), + clearable: true, description: t( 'Limits the number of time series that get displayed. A sub query ' + '(or an extra phase where sub queries are not supported) is applied to limit ' +