QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't strip SQL comments in Explore - 2nd try (#28753)

Browse Source
This commit is contained in:
Maxime Beauchemin
2024-06-20 14:30:03 -07:00
committed by GitHub
parent 5e060cef7c
commit 514eda82fb
9 changed files with 109 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/integration_tests/datasource_tests.py
View File

@@ -538,10 +538,12 @@ def test_get_samples(test_client, login_as_admin, virtual_dataset):
assert "coltypes" in rv2.json["result"]
assert "data" in rv2.json["result"]
eager_samples = virtual_dataset.database.get_df(
f"select * from ({virtual_dataset.sql}) as tbl"
f' limit {app.config["SAMPLES_ROW_LIMIT"]}'
sql = (
f"select * from ({virtual_dataset.sql}) as tbl "
f'limit {app.config["SAMPLES_ROW_LIMIT"]}'
)
eager_samples = virtual_dataset.database.get_df(sql)
# the col3 is Decimal
eager_samples["col3"] = eager_samples["col3"].apply(float)
eager_samples = eager_samples.to_dict(orient="records")