QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't strip SQL comments in Explore - 2nd try (#28753)

Browse Source
This commit is contained in:
Maxime Beauchemin
2024-06-20 14:30:03 -07:00
committed by GitHub
parent 5e060cef7c
commit 514eda82fb
9 changed files with 109 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/integration_tests/query_context_tests.py
View File

@@ -1168,3 +1168,34 @@ OFFSET 0
re.search(r"WHERE\n col6 >= .*2001-10-01", sqls[1])
and re.search(r"AND col6 < .*2002-10-01", sqls[1])
) is not None
def test_virtual_dataset_with_comments(app_context, virtual_dataset_with_comments):
qc = QueryContextFactory().create(
datasource={
"type": virtual_dataset_with_comments.type,
"id": virtual_dataset_with_comments.id,
},
queries=[
{
"columns": ["col1", "col2"],
"metrics": ["count"],
"post_processing": [
{
"operation": "pivot",
"options": {
"aggregates": {"count": {"operator": "mean"}},
"columns": ["col2"],
"index": ["col1"],
},
},
{"operation": "flatten"},
],
}
],
result_type=ChartDataResultType.FULL,
force=True,
)
query_object = qc.queries[0]
df = qc.get_df_payload(query_object)["df"]
assert len(df) == 3