QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't strip SQL comments in Explore - 2nd try (#28753)

Browse Source
This commit is contained in:
Maxime Beauchemin
2024-06-20 14:30:03 -07:00
committed by GitHub
parent 5e060cef7c
commit 514eda82fb
9 changed files with 109 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration_tests/sqla_models_tests.py
View File

@@ -253,7 +253,7 @@ class TestDatabaseModel(SupersetTestCase):
query = table.database.compile_sqla_query(sqla_query.sqla_query)
# assert virtual dataset
assert "SELECT\n 'user_abc' AS user,\n 'xyz_P1D' AS time_grain" in query
assert "SELECT 'user_abc' as user, 'xyz_P1D' as time_grain" in query
# assert dataset calculated column
assert "case when 'abc' = 'abc' then 'yes' else 'no' end" in query
# assert adhoc column