QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(async): Making create app configurable (#25346)

Browse Source
This commit is contained in:
Craig Rueda
2023-09-20 10:04:58 -07:00
committed by GitHub
parent a971a28a34
commit 515452c7e2
18 changed files with 255 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/integration_tests/charts/data/api_tests.py
View File

@@ -45,7 +45,7 @@ from superset.models.slice import Slice
from superset.charts.data.commands.get_data_command import ChartDataCommand
from superset.connectors.sqla.models import TableColumn, SqlaTable
from superset.errors import SupersetErrorType
from superset.extensions import async_query_manager, db
from superset.extensions import async_query_manager_factory, db
from superset.models.annotations import AnnotationLayer
from superset.models.slice import Slice
from superset.superset_typing import AdhocColumn
@@ -626,7 +626,7 @@ class TestPostChartDataApi(BaseTestChartDataApi):
def test_chart_data_async(self):
self.logout()
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
self.login("admin")
rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
self.assertEqual(rv.status_code, 202)
@@ -644,7 +644,7 @@ class TestPostChartDataApi(BaseTestChartDataApi):
when results are already cached.
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
class QueryContext:
result_format = ChartDataResultFormat.JSON
@@ -674,7 +674,7 @@ class TestPostChartDataApi(BaseTestChartDataApi):
Chart data API: Test chart data query non-JSON format (async)
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
self.query_context_payload["result_type"] = "results"
rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
self.assertEqual(rv.status_code, 200)
@@ -686,7 +686,7 @@ class TestPostChartDataApi(BaseTestChartDataApi):
Chart data API: Test chart data query (async)
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
test_client.set_cookie(
"localhost", app.config["GLOBAL_ASYNC_QUERIES_JWT_COOKIE_NAME"], "foo"
)
@@ -1066,7 +1066,7 @@ class TestGetChartDataApi(BaseTestChartDataApi):
Chart data cache API: Test chart data async cache request
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
cache_loader.load.return_value = self.query_context_payload
orig_run = ChartDataCommand.run
@@ -1093,7 +1093,7 @@ class TestGetChartDataApi(BaseTestChartDataApi):
Chart data cache API: Test chart data async cache request with run failure
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
cache_loader.load.return_value = self.query_context_payload
rv = self.get_assert_metric(
f"{CHART_DATA_URI}/test-cache-key", "data_from_cache"
@@ -1111,7 +1111,7 @@ class TestGetChartDataApi(BaseTestChartDataApi):
Chart data cache API: Test chart data async cache request (no login)
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
self.logout()
cache_loader.load.return_value = self.query_context_payload
orig_run = ChartDataCommand.run
@@ -1134,7 +1134,7 @@ class TestGetChartDataApi(BaseTestChartDataApi):
Chart data cache API: Test chart data async cache request with invalid cache key
"""
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
rv = self.get_assert_metric(
f"{CHART_DATA_URI}/test-cache-key", "data_from_cache"
)

6
tests/integration_tests/core_tests.py
View File

@@ -42,7 +42,7 @@ from superset.connectors.sqla.models import SqlaTable
from superset.db_engine_specs.base import BaseEngineSpec
from superset.db_engine_specs.mssql import MssqlEngineSpec
from superset.exceptions import SupersetException
from superset.extensions import async_query_manager, cache_manager
from superset.extensions import async_query_manager_factory, cache_manager
from superset.models import core as models
from superset.models.cache import CacheKey
from superset.models.dashboard import Dashboard
@@ -705,7 +705,7 @@ class TestCore(SupersetTestCase):
"row_limit": 100,
}
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
self.login(username="admin")
rv = self.client.post(
"/superset/explore_json/",
@@ -737,7 +737,7 @@ class TestCore(SupersetTestCase):
"row_limit": 100,
}
app._got_first_request = False
async_query_manager.init_app(app)
async_query_manager_factory.init_app(app)
self.login(username="admin")
rv = self.client.post(
"/superset/explore_json/?results=true",

7
tests/integration_tests/test_app.py
View File

@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from os import environ
from typing import TYPE_CHECKING
from superset.app import create_app
@@ -23,7 +24,11 @@ if TYPE_CHECKING:
from flask.testing import FlaskClient
app = create_app()
superset_config_module = environ.get(
"SUPERSET_CONFIG", "tests.integration_tests.superset_test_config"
)
app = create_app(superset_config_module=superset_config_module)
def login(