QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve URLs for Chart and Dashboard ModelViews (#5544)

Browse Source 
* Improve URLs for Chart and Dashboard ModelViews

Prior to this, the ModelView for Chart and Dashboard would be
at `/slicemodelview/list/` and `/dashboardmodelview/list/`.

Now we have cleaner URLs at `/chart/list/` and `/dashboard/list/`

* Fix unrelated js lint

* addressing comments
This commit is contained in:
Maxime Beauchemin
2018-08-03 12:46:48 -07:00
committed by GitHub
parent 1e155663a7
commit 51bd17d6f6
15 changed files with 43 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
superset/assets/spec/javascripts/dashboard/fixtures/mockSliceEntities.js
View File

@@ -26,7 +26,7 @@ export const sliceEntitiesForChart = {
compare_suffix: 'o10Y',
datasource: datasourceId,
},
edit_url: `/slicemodelview/edit/${sliceId}`,
edit_url: `/chart/edit/${sliceId}`,
viz_type: 'pie',
datasource: datasourceId,
description: null,
@@ -45,7 +45,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20127%7D',
slice_name: 'Region Filter',
form_data: {},
edit_url: '/slicemodelview/edit/127',
edit_url: '/chart/edit/127',
viz_type: 'filter_box',
datasource: '2__table',
description: null,
@@ -58,7 +58,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20128%7D',
slice_name: "World's Population",
form_data: {},
edit_url: '/slicemodelview/edit/128',
edit_url: '/chart/edit/128',
viz_type: 'big_number',
datasource: '2__table',
description: null,
@@ -71,7 +71,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20129%7D',
slice_name: 'Most Populated Countries',
form_data: {},
edit_url: '/slicemodelview/edit/129',
edit_url: '/chart/edit/129',
viz_type: 'table',
datasource: '2__table',
description: null,
@@ -84,7 +84,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20130%7D',
slice_name: 'Growth Rate',
form_data: {},
edit_url: '/slicemodelview/edit/130',
edit_url: '/chart/edit/130',
viz_type: 'line',
datasource: '2__table',
description: null,
@@ -97,7 +97,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20131%7D',
slice_name: '% Rural',
form_data: {},
edit_url: '/slicemodelview/edit/131',
edit_url: '/chart/edit/131',
viz_type: 'world_map',
datasource: '2__table',
description: null,
@@ -110,7 +110,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20132%7D',
slice_name: 'Life Expectancy VS Rural %',
form_data: {},
edit_url: '/slicemodelview/edit/132',
edit_url: '/chart/edit/132',
viz_type: 'bubble',
datasource: '2__table',
description: null,
@@ -123,7 +123,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20133%7D',
slice_name: 'Rural Breakdown',
form_data: {},
edit_url: '/slicemodelview/edit/133',
edit_url: '/chart/edit/133',
viz_type: 'sunburst',
datasource: '2__table',
description: null,
@@ -136,7 +136,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20134%7D',
slice_name: "World's Pop Growth",
form_data: {},
edit_url: '/slicemodelview/edit/134',
edit_url: '/chart/edit/134',
viz_type: 'area',
datasource: '2__table',
description: null,
@@ -149,7 +149,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20135%7D',
slice_name: 'Box plot',
form_data: {},
edit_url: '/slicemodelview/edit/135',
edit_url: '/chart/edit/135',
viz_type: 'box_plot',
datasource: '2__table',
description: null,
@@ -162,7 +162,7 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20136%7D',
slice_name: 'Treemap',
form_data: {},
edit_url: '/slicemodelview/edit/136',
edit_url: '/chart/edit/136',
viz_type: 'treemap',
datasource: '2__table',
description: null,