QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve URLs for Chart and Dashboard ModelViews (#5544)

Browse Source 
* Improve URLs for Chart and Dashboard ModelViews

Prior to this, the ModelView for Chart and Dashboard would be
at `/slicemodelview/list/` and `/dashboardmodelview/list/`.

Now we have cleaner URLs at `/chart/list/` and `/dashboard/list/`

* Fix unrelated js lint

* addressing comments
This commit is contained in:
Maxime Beauchemin
2018-08-03 12:46:48 -07:00
committed by GitHub
parent 1e155663a7
commit 51bd17d6f6
15 changed files with 43 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/spec/javascripts/explore/components/SaveModal_spec.jsx
View File

@@ -192,7 +192,7 @@ describe('SaveModal', () => {
});
it('calls correct url', () => {
const url = '/dashboardmodelviewasync/api/read?_flt_0_owners=' + userID;
const url = '/dashboardasync/api/read?_flt_0_owners=' + userID;
makeRequest();
expect(ajaxStub.getCall(0).args[0].url).to.be.equal(url);
});