QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(native-filters): Hide filters which don't affect any visible charts (#15063)

Browse Source 
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
This commit is contained in:
Kamil Gabryjelski
2021-06-11 13:41:08 +02:00
committed by GitHub
parent 5e825cf063
commit 51f0d4fd98
9 changed files with 111 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
View File

@@ -50,21 +50,21 @@ jest.mock('src/dashboard/actions/dashboardState');
describe('DashboardBuilder', () => {
let favStarStub;
let focusedTabStub;
let activeTabsStub;
beforeAll(() => {
// this is invoked on mount, so we stub it instead of making a request
favStarStub = sinon
.stub(dashboardStateActions, 'fetchFaveStar')
.returns({ type: 'mock-action' });
focusedTabStub = sinon
.stub(dashboardStateActions, 'setLastFocusedTab')
activeTabsStub = sinon
.stub(dashboardStateActions, 'setActiveTabs')
.returns({ type: 'mock-action' });
});
afterAll(() => {
favStarStub.restore();
focusedTabStub.restore();
activeTabsStub.restore();
});
function setup(overrideState = {}, overrideStore) {