QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-12 12:47:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: SHOW is not DML (#13464)

Browse Source 
* fix: SHOW is not DML

* Fix test
This commit is contained in:
Beto Dealmeida
2021-03-04 17:17:25 -08:00
committed by GitHub
parent d2e03ab9b4
commit 528ea9cbb0
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/db_engine_specs/base_engine_spec_tests.py
View File

@@ -263,9 +263,11 @@ def test_is_readonly():
def is_readonly(sql: str) -> bool:
return BaseEngineSpec.is_readonly_query(ParsedQuery(sql))
assert not is_readonly("SHOW LOCKS test EXTENDED")
assert is_readonly("SHOW LOCKS test EXTENDED")
assert not is_readonly("SET hivevar:desc='Legislators'")
assert not is_readonly("UPDATE t1 SET col1 = NULL")
assert is_readonly("EXPLAIN SELECT 1")
assert is_readonly("SELECT 1")
assert is_readonly("WITH (SELECT 1) bla SELECT * from bla")
assert is_readonly("SHOW CATALOGS")
assert is_readonly("SHOW TABLES")