QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Table chart): fix percentage metric column (#34175)

Browse Source
This commit is contained in:
Levis Mbote
2025-08-06 17:51:02 +03:00
committed by GitHub
parent 246181a546
commit 53503e32ae
6 changed files with 279 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
View File

@@ -36,18 +36,19 @@ import {
QueryModeLabel,
sections,
sharedControls,
shouldSkipMetricColumn,
isRegularMetric,
isPercentMetric,
} from '@superset-ui/chart-controls';
import {
ensureIsArray,
FeatureFlag,
GenericDataType,
getMetricLabel,
isAdhocColumn,
isFeatureEnabled,
isPhysicalColumn,
legacyValidateInteger,
QueryFormColumn,
QueryFormMetric,
QueryMode,
SMART_DATE_ID,
t,
@@ -533,14 +534,25 @@ const config: ControlPanelConfig = {
)
.forEach((colname, index) => {
if (
explore.form_data.metrics?.some(
metric => getMetricLabel(metric) === colname,
) ||
explore.form_data.percent_metrics?.some(
(metric: QueryFormMetric) =>
getMetricLabel(metric) === colname,
)
shouldSkipMetricColumn({
colname,
colnames,
formData: explore.form_data,
})
) {
return;
}
const isMetric = isRegularMetric(
colname,
explore.form_data,
);
const isPercentMetricValue = isPercentMetric(
colname,
explore.form_data,
);
if (isMetric || isPercentMetricValue) {
const comparisonColumns =
generateComparisonColumns(colname);
comparisonColumns.forEach((name, idx) => {