QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-09-09 08:44:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): use dialect-specific quote chars for autocomplete identifiers (#41492)

Browse Source 
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Amin Ghadersohi <amin.ghadersohi@gmail.com>
Co-authored-by: Joe Li <joe@preset.io>
This commit is contained in:
Evan Rusackas
2026-08-13 14:04:38 -07:00
committed by GitHub
co-authored by Claude Opus 4.8 Amin Ghadersohi Joe Li
parent 8f78f9eb9c
commit 537f0fd2db
27 changed files with 661 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration_tests/databases/api_tests.py
+40
View File
@@ -3545,6 +3545,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": '"',
"end": '"',
"escape_by_doubling": True,
},
},
"supports_oauth2": False,
},
@@ -3575,6 +3580,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": "`",
"end": "`",
"escape_by_doubling": False,
},
},
"supports_oauth2": False,
},
@@ -3635,6 +3645,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": '"',
"end": '"',
"escape_by_doubling": True,
},
},
"supports_oauth2": False,
},
@@ -3682,6 +3697,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": True,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": '"',
"end": '"',
"escape_by_doubling": True,
},
},
"supports_oauth2": True,
},
@@ -3742,6 +3762,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": "`",
"end": "`",
"escape_by_doubling": True,
},
},
"supports_oauth2": False,
},
@@ -3758,6 +3783,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": '"',
"end": '"',
"escape_by_doubling": True,
},
},
"supports_oauth2": False,
},
@@ -3794,6 +3824,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": "`",
"end": "`",
"escape_by_doubling": True,
},
},
"supports_oauth2": False,
},
@@ -3810,6 +3845,11 @@ class TestDatabaseApi(SupersetTestCase):
"supports_oauth2": False,
"supports_offset": True,
"supports_schemas": True,
"identifier_quote": {
"start": '"',
"end": '"',
"escape_by_doubling": True,
},
},
"supports_oauth2": False,
},