QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-29 11:45:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(echarts): suppress phantom x-axis label at axis edge when no time grain (#39972)

Browse Source
This commit is contained in:
jesperct
2026-05-18 13:52:48 -03:00
committed by GitHub
parent 054aeb3bae
commit 5393fdfabf
4 changed files with 36 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
View File

@@ -1444,7 +1444,7 @@ test('x-axis formatter deduplicates consecutive identical labels for coarse time
const chartProps = createTestChartProps({
formData: {
granularity_sqla: 'ds',
time_grain_sqla: TimeGranularity.YEAR,
timeGrainSqla: TimeGranularity.YEAR,
xAxisTimeFormat: '%Y',
},
queriesData: [
@@ -1473,6 +1473,30 @@ test('x-axis formatter deduplicates consecutive identical labels for coarse time
expect(label4).toBe('');
});
test('x-axis does not force showMaxLabel when no time grain is set', () => {
const data = [
{ __timestamp: Date.UTC(2003, 0, 6), sales: 100 },
{ __timestamp: Date.UTC(2004, 5, 15), sales: 200 },
{ __timestamp: Date.UTC(2005, 4, 31), sales: 300 },
];
const chartProps = createTestChartProps({
formData: {
granularity_sqla: 'ds',
timeGrainSqla: undefined,
},
queriesData: [
createTestQueryData(data, {
colnames: ['__timestamp', 'sales'],
coltypes: [GenericDataType.Temporal, GenericDataType.Numeric],
}),
],
});
const xAxisResult = transformProps(chartProps).echartOptions.xAxis as any;
expect(xAxisResult.axisLabel.showMaxLabel).not.toBe(true);
});
test('numeric x coltype routes through the number formatter (not the time formatter)', () => {
// Regression guard for echarts-timeseries-epoch-x-axis-labels investigation.
// When the query reports a Numeric x-axis coltype (including epoch-ms-like