chore: deprecate rls base related filters (#24128)

This commit is contained in:
Ville Brofeldt
2023-05-19 21:55:05 +03:00
committed by GitHub
parent 8b4222ff9e
commit 5424b95138
5 changed files with 26 additions and 66 deletions

View File

@@ -24,7 +24,6 @@ from flask_appbuilder.models.sqla.interface import SQLAInterface
from flask_babel import ngettext
from marshmallow import ValidationError
from superset import app
from superset.commands.exceptions import (
DatasourceNotFoundValidationError,
RolesNotFoundValidationError,
@@ -44,11 +43,13 @@ from superset.row_level_security.schemas import (
RLSPutSchema,
RLSShowSchema,
)
from superset.views.base import DatasourceFilter
from superset.views.base_api import (
BaseSupersetModelRestApi,
requires_json,
statsd_metrics,
)
from superset.views.filters import BaseFilterRelatedRoles
logger = logging.getLogger(__name__)
@@ -122,7 +123,10 @@ class RLSRestApi(BaseSupersetModelRestApi):
edit_model_schema = RLSPutSchema()
allowed_rel_fields = {"tables", "roles"}
base_related_field_filters = app.config["RLS_BASE_RELATED_FIELD_FILTERS"]
base_related_field_filters = {
"tables": [["id", DatasourceFilter, lambda: []]],
"roles": [["id", BaseFilterRelatedRoles, lambda: []]],
}
@expose("/", methods=("POST",))
@protect()