QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add validator information to email/slack alerts (#10762)

Browse Source 
* added validator info to alerts

* adjusted format of messages

* added nits

Co-authored-by: Jason Davis <@dropbox.com>
This commit is contained in:
Jason Davis
2020-09-03 08:15:05 -07:00
committed by GitHub
parent 824cea24ba
commit 54ae3b044f
6 changed files with 42 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/alerts_tests.py
View File

@@ -310,7 +310,7 @@ def test_deliver_alert_screenshot(
screenshot_mock, url_mock, email_mock, file_upload_mock, setup_database
):
dbsession = setup_database
alert = create_alert(dbsession, "SELECT 55")
alert = create_alert(dbsession, "SELECT 55", "not null", "{}")
observe(alert.id)
screenshot = read_fixture("sample.png")
@@ -328,9 +328,10 @@ def test_deliver_alert_screenshot(
"channels": alert.slack_channel,
"file": screenshot,
"initial_comment": f"\n*Triggered Alert: {alert.label} :redalert:*\n"
f"*SQL* *Statement*:```{alert.sql_observer[0].sql}```\n"
f"*SQL* *Result*: {alert.observations[-1].value}"
f"\n<http://0.0.0.0:8080/alert/show/{alert.id}"
f"*Query*:```{alert.sql_observer[0].sql}```\n"
f"*Result*: {alert.observations[-1].value}\n"
f"*Reason*: {alert.observations[-1].value} {alert.validators[0].pretty_print()}\n"
f"<http://0.0.0.0:8080/alert/show/{alert.id}"
f"|View Alert Details>\n<http://0.0.0.0:8080/superset/slice/{alert.slice_id}/"
"|*Explore in Superset*>",
"title": f"[Alert] {alert.label}",