From 5567828ee8005a5a4e0ebeb8d7df36a8136448ac Mon Sep 17 00:00:00 2001
From: smileydev <47900232+prosdev0107@users.noreply.github.com>
Date: Wed, 20 Apr 2022 15:58:25 -0400
Subject: [PATCH] fix(chart & explore): Show labels for `SliderControl`
(#19765)
* fix(chart & explore): make to show label of slidercontrol
* fix(chart & explore): make to update SliderControl props
* fix(chart & explore): make to fix lint
(cherry picked from commit dfbaba97c61c28ecde8ce134a1f6ec385467c383)
---
.../components/controls/SliderControl.tsx | 41 ++++++++++++++++---
1 file changed, 36 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/SliderControl.tsx b/superset-frontend/src/explore/components/controls/SliderControl.tsx
index 5907e26ba83..a2d3b7c2bce 100644
--- a/superset-frontend/src/explore/components/controls/SliderControl.tsx
+++ b/superset-frontend/src/explore/components/controls/SliderControl.tsx
@@ -18,19 +18,50 @@
*/
import React from 'react';
import Slider from 'src/components/Slider';
-import ControlHeader from 'src/explore/components/ControlHeader';
+import ControlHeader, {
+ ControlHeaderProps,
+} from 'src/explore/components/ControlHeader';
-type SliderControlProps = {
+type SliderControlProps = ControlHeaderProps & {
onChange: (value: number) => void;
value: number;
default?: number;
};
-export default function SliderControl(props: SliderControlProps) {
- const { onChange = () => {}, default: defaultValue, ...rest } = props;
+export default function SliderControl({
+ default: defaultValue,
+ name,
+ label,
+ description,
+ renderTrigger,
+ rightNode,
+ leftNode,
+ validationErrors,
+ hovered,
+ warning,
+ danger,
+ onClick,
+ tooltipOnClick,
+ onChange = () => {},
+ ...rest
+}: SliderControlProps) {
+ const headerProps = {
+ name,
+ label,
+ description,
+ renderTrigger,
+ rightNode,
+ leftNode,
+ validationErrors,
+ onClick,
+ hovered,
+ tooltipOnClick,
+ warning,
+ danger,
+ };
return (
<>
-
+
>
);