QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 15:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

ESLint: Enable rule no-named-as-default (#10879)

Browse Source 
* Enable rule no-named-as-default

* Fix wrong import
This commit is contained in:
Kamil Gabryjelski
2020-09-18 22:41:01 +02:00
committed by GitHub
parent 91fd06e093
commit 557a303cc5
19 changed files with 21 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/spec/javascripts/explore/components/ExploreViewContainer_spec.jsx
View File

@@ -25,7 +25,7 @@ import { shallow } from 'enzyme';
import getInitialState from 'src/explore/reducers/getInitialState';
import ExploreViewContainer from 'src/explore/components/ExploreViewContainer';
import QueryAndSaveBtns from 'src/explore/components/QueryAndSaveBtns';
import ControlPanelsContainer from 'src/explore/components/ControlPanelsContainer';
import ConnectedControlPanelsContainer from 'src/explore/components/ControlPanelsContainer';
import ChartContainer from 'src/explore/components/ExploreChartPanel';
import * as featureFlags from 'src/featureFlags';
@@ -72,7 +72,7 @@ describe('ExploreViewContainer', () => {
});
it('renders ControlPanelsContainer', () => {
expect(wrapper.find(ControlPanelsContainer)).toExist();
expect(wrapper.find(ConnectedControlPanelsContainer)).toExist();
});
it('renders ChartContainer', () => {

10
superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
View File

@@ -25,7 +25,7 @@ import {
} from 'src/SqlLab/constants';
import AceEditorWrapper from 'src/SqlLab/components/AceEditorWrapper';
import LimitControl from 'src/SqlLab/components/LimitControl';
import SouthPane from 'src/SqlLab/components/SouthPane';
import ConnectedSouthPane from 'src/SqlLab/components/SouthPane';
import SqlEditor from 'src/SqlLab/components/SqlEditor';
import SqlEditorLeftBar from 'src/SqlLab/components/SqlEditorLeftBar';
@@ -64,15 +64,15 @@ describe('SqlEditor', () => {
const wrapper = shallow(<SqlEditor {...mockedProps} />);
expect(wrapper.find(AceEditorWrapper)).toExist();
});
it('render an SouthPane', () => {
it('render a SouthPane', () => {
const wrapper = shallow(<SqlEditor {...mockedProps} />);
expect(wrapper.find(SouthPane)).toExist();
expect(wrapper.find(ConnectedSouthPane)).toExist();
});
it('does not overflow the editor window', () => {
const wrapper = shallow(<SqlEditor {...mockedProps} />);
const totalSize =
parseFloat(wrapper.find(AceEditorWrapper).props().height) +
wrapper.find(SouthPane).props().height +
wrapper.find(ConnectedSouthPane).props().height +
SQL_TOOLBAR_HEIGHT +
SQL_EDITOR_GUTTER_MARGIN * 2 +
SQL_EDITOR_GUTTER_HEIGHT;
@@ -83,7 +83,7 @@ describe('SqlEditor', () => {
wrapper.setState({ height: 450 });
const totalSize =
parseFloat(wrapper.find(AceEditorWrapper).props().height) +
wrapper.find(SouthPane).props().height +
wrapper.find(ConnectedSouthPane).props().height +
SQL_TOOLBAR_HEIGHT +
SQL_EDITOR_GUTTER_MARGIN * 2 +
SQL_EDITOR_GUTTER_HEIGHT;