feat(metrics): Provide override for disabling ad-hoc metrics (#17202)

Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley
2021-11-08 10:31:43 -08:00
committed by GitHub
parent 33a8e87513
commit 561d1ac9f2
11 changed files with 199 additions and 137 deletions

View File

@@ -284,7 +284,7 @@ export const DndMetricSelect = (props: any) => {
columns={props.columns}
savedMetrics={props.savedMetrics}
savedMetricsOptions={getSavedMetricOptionsForMetric(index)}
datasourceType={props.datasourceType}
datasource={props.datasource}
onMoveLabel={moveLabel}
onDropLabel={handleDropLabel}
type={`${DndItemType.AdhocMetricOption}_${props.name}_${props.label}`}
@@ -299,7 +299,7 @@ export const DndMetricSelect = (props: any) => {
onMetricEdit,
onRemoveMetric,
props.columns,
props.datasourceType,
props.datasource,
props.label,
props.name,
props.savedMetrics,
@@ -396,7 +396,7 @@ export const DndMetricSelect = (props: any) => {
columns={props.columns}
savedMetricsOptions={newSavedMetricOptions}
savedMetric={EMPTY_OBJECT as savedMetricType}
datasourceType={props.datasourceType}
datasource={props.datasource}
isControlledComponent
visible={newMetricPopoverVisible}
togglePopover={togglePopover}