QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: DB-specific quoting in Jinja macro (#25779)

Browse Source
This commit is contained in:
Beto Dealmeida
2023-10-30 09:50:44 -04:00
committed by GitHub
parent ed14f36c55
commit 5659c87ed2
2 changed files with 38 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/unit_tests/jinja_context_test.py
View File

@@ -20,17 +20,22 @@ import json
import pytest
from pytest_mock import MockFixture
from sqlalchemy.dialects import mysql
from superset.datasets.commands.exceptions import DatasetNotFoundError
from superset.jinja_context import dataset_macro, where_in
from superset.jinja_context import dataset_macro, WhereInMacro
def test_where_in() -> None:
"""
Test the ``where_in`` Jinja2 filter.
"""
where_in = WhereInMacro(mysql.dialect())
assert where_in([1, "b", 3]) == "(1, 'b', 3)"
assert where_in([1, "b", 3], '"') == '(1, "b", 3)'
assert where_in([1, "b", 3], '"') == (
"(1, 'b', 3)\n-- WARNING: the `mark` parameter was removed from the "
"`where_in` macro for security reasons\n"
)
assert where_in(["O'Malley's"]) == "('O''Malley''s')"