QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve time shift (#5140)

Browse Source 
* Improve time shift color and pattern

* Revert change

* Fix js unit test

* Move code to better place, add unit test

* Move classed code to backend

* Remove console.log

* Remove 1 hour time compare

* Remove unused import
This commit is contained in:
Beto Dealmeida
2018-06-06 20:40:55 -07:00
committed by Maxime Beauchemin
parent 0545d11a22
commit 57e125688f
6 changed files with 45 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/assets/spec/javascripts/visualizations/nvd3_viz_spec.jsx
View File

@@ -20,9 +20,9 @@ describe('nvd3 viz', () => {
expect(formatLabel(['foo'], verboseMap)).to.equal('Foo');
expect(formatLabel(['foo', 'bar', 'baz'], verboseMap)).to.equal('Foo, Bar, baz');
});
it('deals with --- properly', () => {
expect(formatLabel(['foo', '---'], verboseMap)).to.equal('Foo ---');
expect(formatLabel(['foo', 'bar', 'baz', '---'], verboseMap)).to.equal('Foo, Bar, baz ---');
it('deals with time shift properly', () => {
expect(formatLabel(['foo', '1 hour offset'], verboseMap)).to.equal('Foo, 1 hour offset');
expect(formatLabel(['foo', 'bar', 'baz', '2 hours offset'], verboseMap)).to.equal('Foo, Bar, baz, 2 hours offset');
});
});
});