QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sqllab] add support for Jinja templating (#1426)

Browse Source 
* [sqllab] add support for Jinja templating

* Adressing comments

* Presto macros

* Progress

* Addressing coments
This commit is contained in:
Maxime Beauchemin
2016-10-26 11:09:27 -07:00
committed by GitHub
parent 8c5e495272
commit 5944643da6
20 changed files with 444 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
caravel/assets/javascripts/components/ModalTrigger.jsx
View File

@@ -5,7 +5,7 @@ import cx from 'classnames';
const propTypes = {
triggerNode: PropTypes.node.isRequired,
modalTitle: PropTypes.node.isRequired,
modalBody: PropTypes.node.isRequired,
modalBody: PropTypes.node, // not required because it can be generated by beforeOpen
beforeOpen: PropTypes.func,
onExit: PropTypes.func,
isButton: PropTypes.bool,
@@ -46,8 +46,8 @@ export default class ModalTrigger extends React.Component {
'btn btn-default btn-sm': this.props.isButton,
});
return (
<a href="#" className={classNames} onClick={this.open}>
{this.props.triggerNode}
<span className={classNames} onClick={this.open} style={{ cursor: 'pointer' }}>
{this.props.triggerNode}
<Modal
show={this.state.showModal}
onHide={this.close}
@@ -62,7 +62,7 @@ export default class ModalTrigger extends React.Component {
{this.props.modalBody}
</Modal.Body>
</Modal>
</a>
</span>
);
}
}