QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-24 18:44:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sqllab): Remove tableOptions from redux state (#23488)

Browse Source
This commit is contained in:
JUST.in DO IT
2023-04-20 15:55:55 -07:00
committed by GitHub
parent a09162bb37
commit 5bec1a65ae
9 changed files with 12 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
View File

@@ -39,7 +39,7 @@ import {
FullSQLEditor as AceEditor,
} from 'src/components/AsyncAceEditor';
import useQueryEditor from 'src/SqlLab/hooks/useQueryEditor';
import { useSchemas } from 'src/hooks/apiResources';
import { useSchemas, useTables } from 'src/hooks/apiResources';
type HotKey = {
key: string;
@@ -96,11 +96,19 @@ const AceEditorWrapper = ({
'dbId',
'sql',
'functionNames',
'tableOptions',
'validationResult',
'schema',
]);
const { data: schemaOptions } = useSchemas({ dbId: queryEditor.dbId });
const { data: schemaOptions } = useSchemas({
...(autocomplete && { dbId: queryEditor.dbId }),
});
const { data: tableData } = useTables({
...(autocomplete && {
dbId: queryEditor.dbId,
schema: queryEditor.schema,
}),
});
const currentSql = queryEditor.sql ?? '';
const functionNames = queryEditor.functionNames ?? [];
@@ -117,7 +125,7 @@ const AceEditorWrapper = ({
}),
[schemaOptions],
);
const tables = queryEditor.tableOptions ?? [];
const tables = tableData?.options ?? [];
const [sql, setSql] = useState(currentSql);
const [words, setWords] = useState<AceCompleterKeyword[]>([]);