QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explore view] inline edit slice name should not overwrite (#9817)

Browse Source
This commit is contained in:
Grace Guo
2020-05-18 22:53:29 -07:00
committed by GitHub
parent c117e222c0
commit 5ca6ed716f
8 changed files with 32 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx
View File

@@ -23,12 +23,12 @@ import { ExploreChartHeader } from 'src/explore/components/ExploreChartHeader';
import ExploreActionButtons from 'src/explore/components/ExploreActionButtons';
import EditableTitle from 'src/components/EditableTitle';
const stub = jest.fn(() => ({
then: () => {},
}));
const saveSliceStub = jest.fn();
const updateChartTitleStub = jest.fn();
const mockProps = {
actions: {
saveSlice: stub,
saveSlice: saveSliceStub,
updateChartTitle: updateChartTitleStub,
},
can_overwrite: true,
can_download: true,
@@ -65,24 +65,9 @@ describe('ExploreChartHeader', () => {
expect(wrapper.find(ExploreActionButtons)).toHaveLength(1);
});
it('should updateChartTitleOrSaveSlice for existed slice', () => {
it('should update title but not save', () => {
const newTitle = 'New Chart Title';
wrapper.instance().updateChartTitleOrSaveSlice(newTitle);
expect(stub.call).toHaveLength(1);
expect(stub).toHaveBeenCalledWith(mockProps.slice.form_data, {
action: 'overwrite',
slice_name: newTitle,
});
});
it('should updateChartTitleOrSaveSlice for new slice', () => {
const newTitle = 'New Chart Title';
wrapper.setProps({ slice: undefined });
wrapper.instance().updateChartTitleOrSaveSlice(newTitle);
expect(stub.call).toHaveLength(1);
expect(stub).toHaveBeenCalledWith(mockProps.form_data, {
action: 'saveas',
slice_name: newTitle,
});
const editableTitle = wrapper.find(EditableTitle);
expect(editableTitle.props().onSaveTitle).toBe(updateChartTitleStub);
});
});