QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): default XY chart x-axis to dataset primary datetime column (#39421)

Browse Source 
Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>
This commit is contained in:
Amin Ghadersohi
2026-04-20 11:14:54 -04:00
committed by GitHub
parent 16387b0815
commit 5cff657812
8 changed files with 132 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
superset/mcp_service/chart/validation/schema_validator.py
View File

@@ -185,22 +185,15 @@ class SchemaValidator:
config: Dict[str, Any],
) -> Tuple[bool, ChartGenerationError | None]:
"""Pre-validate XY chart configuration."""
missing_fields = []
if "x" not in config:
missing_fields.append("'x' (X-axis column)")
# x is optional — defaults to dataset's main_dttm_col in map_xy_config
if "y" not in config:
missing_fields.append("'y' (Y-axis metrics)")
if missing_fields:
return False, ChartGenerationError(
error_type="missing_xy_fields",
message=f"XY chart missing required "
f"fields: {', '.join(missing_fields)}",
details="XY charts require both X-axis (dimension) and Y-axis ("
"metrics) specifications",
message="XY chart missing required field: 'y' (Y-axis metrics)",
details="XY charts require Y-axis (metrics) specifications. "
"X-axis is optional and defaults to the dataset's primary "
"datetime column when omitted.",
suggestions=[
"Add 'x' field: {'name': 'column_name'} for X-axis",
"Add 'y' field: [{'name': 'metric_column', 'aggregate': 'SUM'}] "
"for Y-axis",
"Example: {'chart_type': 'xy', 'x': {'name': 'date'}, "