QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-12 20:57:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugin-chart-table): Invalid d3Formatter on String column (#23515)

Browse Source
This commit is contained in:
JUST.in DO IT
2023-03-28 15:25:35 -07:00
committed by GitHub
parent 80d1e4ffa3
commit 5d910aa2e2
3 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
View File

@@ -119,6 +119,7 @@ const processColumns = memoizeOne(function processColumns(
const isMetric = metricsSet.has(key) && isNumeric(key, records);
const isPercentMetric = percentMetricsSet.has(key);
const isTime = dataType === GenericDataType.TEMPORAL;
const isNumber = dataType === GenericDataType.NUMERIC;
const savedFormat = columnFormats?.[key];
const numberFormat = config.d3NumberFormat || savedFormat;
@@ -151,7 +152,7 @@ const processColumns = memoizeOne(function processColumns(
} else if (isPercentMetric) {
// percent metrics have a default format
formatter = getNumberFormatter(numberFormat || PERCENT_3_POINT);
} else if (isMetric || numberFormat) {
} else if (isMetric || (isNumber && numberFormat)) {
formatter = getNumberFormatter(numberFormat);
}
return {