feat: cancel impala query on stop (#30412)

tests/unit_tests/db_engine_specs/test_impala.py

@@ -17,9 +17,13 @@
 
 from datetime import datetime
 from typing import Optional
+from unittest.mock import Mock, patch
 
 import pytest
 
+from superset.db_engine_specs.impala import ImpalaEngineSpec as spec
+from superset.models.core import Database
+from superset.models.sql_lab import Query
 from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm
 from tests.unit_tests.fixtures.common import dttm  # noqa: F401
 
@@ -37,6 +41,77 @@ def test_convert_dttm(
     expected_result: Optional[str],
     dttm: datetime,  # noqa: F811
 ) -> None:
-    from superset.db_engine_specs.impala import ImpalaEngineSpec as spec
-
     assert_convert_dttm(spec, target_type, expected_result, dttm)
+
+
+def test_get_cancel_query_id() -> None:
+    query = Query()
+
+    cursor_mock = Mock()
+    last_operation_mock = Mock()
+    cursor_mock._last_operation = last_operation_mock
+
+    guid = bytes(reversed(bytes.fromhex("9fbdba20000000006940643a2731718b")))
+    last_operation_mock.handle.operationId.guid = guid
+
+    assert (
+        spec.get_cancel_query_id(cursor_mock, query)
+        == "6940643a2731718b:9fbdba2000000000"
+    )
+
+
+@patch("requests.post")
+def test_cancel_query(post_mock: Mock) -> None:
+    query = Query()
+    database = Database(
+        database_name="test_impala", sqlalchemy_uri="impala://localhost:21050/default"
+    )
+    query.database = database
+
+    response_mock = Mock()
+    response_mock.status_code = 200
+    post_mock.return_value = response_mock
+
+    result = spec.cancel_query(None, query, "6940643a2731718b:9fbdba2000000000")
+
+    post_mock.assert_called_once_with(
+        "http://localhost:25000/cancel_query?query_id=6940643a2731718b:9fbdba2000000000",
+        timeout=3,
+    )
+    assert result is True
+
+
+@patch("requests.post")
+def test_cancel_query_failed(post_mock: Mock) -> None:
+    query = Query()
+    database = Database(
+        database_name="test_impala", sqlalchemy_uri="impala://localhost:21050/default"
+    )
+    query.database = database
+
+    response_mock = Mock()
+    response_mock.status_code = 500
+    post_mock.return_value = response_mock
+
+    result = spec.cancel_query(None, query, "6940643a2731718b:9fbdba2000000000")
+
+    post_mock.assert_called_once_with(
+        "http://localhost:25000/cancel_query?query_id=6940643a2731718b:9fbdba2000000000",
+        timeout=3,
+    )
+    assert result is False
+
+
+@patch("requests.post")
+def test_cancel_query_exception(post_mock: Mock) -> None:
+    query = Query()
+    database = Database(
+        database_name="test_impala", sqlalchemy_uri="impala://localhost:21050/default"
+    )
+    query.database = database
+
+    post_mock.side_effect = Exception("Network error")
+
+    result = spec.cancel_query(None, query, "6940643a2731718b:9fbdba2000000000")
+
+    assert result is False