mirror of
https://github.com/apache/superset.git
synced 2026-04-22 17:45:21 +00:00
feat(explore): SQL popover in datasource panel (#19308)
* feat(explore): SQL popover in datasource panel * Fix acequire not defined * Rebase and fix tests * Disable highlighting gutter * Use ace-build acequire instead of brace
This commit is contained in:
committed by
GitHub
parent
90dbe8d340
commit
60dcd651f4
@@ -24,7 +24,6 @@ import {
|
||||
getByText,
|
||||
waitFor,
|
||||
} from 'spec/helpers/testing-library';
|
||||
import brace from 'brace';
|
||||
import { ThemeProvider, supersetTheme } from '@superset-ui/core';
|
||||
|
||||
import TemplateParamsEditor from 'src/SqlLab/components/TemplateParamsEditor';
|
||||
@@ -48,8 +47,6 @@ describe('TemplateParamsEditor', () => {
|
||||
{ wrapper: ThemeWrapper },
|
||||
);
|
||||
fireEvent.click(getByText(container, 'Parameters'));
|
||||
const spy = jest.spyOn(brace, 'acequire');
|
||||
spy.mockReturnValue({ setCompleters: () => 'foo' });
|
||||
await waitFor(() => {
|
||||
expect(baseElement.querySelector('#ace-editor')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
@@ -74,7 +74,6 @@ function TemplateParamsEditor({
|
||||
syntax.
|
||||
</p>
|
||||
<StyledConfigEditor
|
||||
keywords={[]}
|
||||
mode={language}
|
||||
minLines={25}
|
||||
maxLines={50}
|
||||
|
||||
Reference in New Issue
Block a user