mirror of
https://github.com/apache/superset.git
synced 2026-04-24 02:25:13 +00:00
feat: Update ShortKey for stop query running in SqlLab editor (#19692)
* feat: Update shortkey for stop query running in sqllab editor * resolve comment * fix invalid import useMemo
This commit is contained in:
@@ -16,7 +16,7 @@
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
import React from 'react';
|
||||
import React, { useMemo } from 'react';
|
||||
import { t, styled, useTheme } from '@superset-ui/core';
|
||||
|
||||
import { Menu } from 'src/components/Menu';
|
||||
@@ -26,6 +26,7 @@ import {
|
||||
DropdownButton,
|
||||
DropdownButtonProps,
|
||||
} from 'src/components/DropdownButton';
|
||||
import { detectOS } from 'src/utils/common';
|
||||
|
||||
interface Props {
|
||||
allowAsync: boolean;
|
||||
@@ -95,6 +96,8 @@ const RunQueryActionButton = ({
|
||||
}: Props) => {
|
||||
const theme = useTheme();
|
||||
|
||||
const userOS = detectOS();
|
||||
|
||||
const shouldShowStopBtn =
|
||||
!!queryState && ['running', 'pending'].indexOf(queryState) > -1;
|
||||
|
||||
@@ -104,6 +107,14 @@ const RunQueryActionButton = ({
|
||||
|
||||
const isDisabled = !sql.trim();
|
||||
|
||||
const stopButtonTooltipText = useMemo(
|
||||
() =>
|
||||
userOS === 'MacOS'
|
||||
? t('Stop running (Ctrl + x)')
|
||||
: t('Stop running (Ctrl + e)'),
|
||||
[userOS],
|
||||
);
|
||||
|
||||
return (
|
||||
<StyledButton>
|
||||
<ButtonComponent
|
||||
@@ -114,7 +125,7 @@ const RunQueryActionButton = ({
|
||||
tooltip={
|
||||
(!isDisabled &&
|
||||
(shouldShowStopBtn
|
||||
? t('Stop running (Ctrl + x)')
|
||||
? stopButtonTooltipText
|
||||
: t('Run query (Ctrl + Return)'))) as string
|
||||
}
|
||||
cta
|
||||
|
||||
Reference in New Issue
Block a user