QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(FilterBox): treat empty defaultValues as null (#13109)

Browse Source 
* fix(FilterBox): treat empty defaultValues as null

* Add a unit test and move constant around
This commit is contained in:
Jesse Yang
2021-02-15 06:35:47 -10:00
committed by GitHub
parent d0b00bc08f
commit 613945a200
6 changed files with 60 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
superset-frontend/spec/javascripts/dashboard/util/getFilterConfigsFromFormdata_spec.js
View File

@@ -56,13 +56,25 @@ describe('getFilterConfigsFromFormdata', () => {
});
});
it('should use default value from form_data', () => {
it('should use default value and treat empty defaults as null', () => {
const result = getFilterConfigsFromFormdata({
...testFormdata,
show_sqla_time_column: true,
filter_configs: [
...testFormdata.filter_configs,
{
asc: false,
clearable: true,
column: 'country',
defaultValue: '',
key: 'foo',
multiple: true,
},
],
});
expect(result.columns).toMatchObject({
state: ['CA'],
country: null,
});
});