QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: create permissions on DB import (#29802)

Browse Source
This commit is contained in:
Beto Dealmeida
2024-08-06 12:09:21 -04:00
committed by GitHub
parent 1c3ef01209
commit 61c0970968
18 changed files with 273 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration_tests/datasets/commands_tests.py
View File

@@ -343,8 +343,9 @@ class TestImportDatasetsCommand(SupersetTestCase):
@patch("superset.utils.core.g")
@patch("superset.security.manager.g")
@patch("superset.commands.database.importers.v1.utils.add_permissions")
@pytest.mark.usefixtures("load_energy_table_with_slice")
def test_import_v1_dataset(self, sm_g, utils_g):
def test_import_v1_dataset(self, mock_add_permissions, sm_g, utils_g):
"""Test that we can import a dataset"""
admin = sm_g.user = utils_g.user = security_manager.find_user("admin")
contents = {
@@ -411,7 +412,8 @@ class TestImportDatasetsCommand(SupersetTestCase):
db.session.commit()
@patch("superset.security.manager.g")
def test_import_v1_dataset_multiple(self, mock_g):
@patch("superset.commands.database.importers.v1.utils.add_permissions")
def test_import_v1_dataset_multiple(self, mock_add_permissions, mock_g):
"""Test that a dataset can be imported multiple times"""
mock_g.user = security_manager.find_user("admin")
@@ -452,7 +454,8 @@ class TestImportDatasetsCommand(SupersetTestCase):
db.session.delete(dataset.database)
db.session.commit()
def test_import_v1_dataset_validation(self):
@patch("superset.commands.database.importers.v1.utils.add_permissions")
def test_import_v1_dataset_validation(self, mock_add_permissions):
"""Test different validations applied when importing a dataset"""
# metadata.yaml must be present
contents = {
@@ -502,7 +505,8 @@ class TestImportDatasetsCommand(SupersetTestCase):
}
@patch("superset.security.manager.g")
def test_import_v1_dataset_existing_database(self, mock_g):
@patch("superset.commands.database.importers.v1.utils.add_permissions")
def test_import_v1_dataset_existing_database(self, mock_add_permissions, mock_g):
"""Test that a dataset can be imported when the database already exists"""
mock_g.user = security_manager.find_user("admin")