chore(python-testing): move memoized tests to unit tests (#15507)

* chore: move memoized test into a separated file

create integration test workflow

* chore: create unit test workflow to run purely pytest

* fix: bad reference

* fix: remove pip requirements bc there aren't any yet

* temp: install unit dependencies directly

* fix: --rootdir=

* fix: try to run only unit test

* chore: decouple memoized as separated module

* fix: bring back dependencies bc superset top-level module is coupled to flask and others so no reason no to do it

* fix: reference

* fix: pre-commit

* fix: pylint

tests/integration_tests/utils_tests.py

@@ -57,7 +57,6 @@ from superset.utils.core import (
     json_int_dttm_ser,
     json_iso_dttm_ser,
     JSONEncodedDict,
-    memoized,
     merge_extra_filters,
     merge_extra_form_data,
     merge_request_params,
@@ -581,79 +580,6 @@ class TestUtils(SupersetTestCase):
         with self.assertRaises(SupersetException):
             validate_json(invalid)
 
-    def test_memoized_on_functions(self):
-        watcher = {"val": 0}
-
-        @memoized
-        def test_function(a, b, c):
-            watcher["val"] += 1
-            return a * b * c
-
-        result1 = test_function(1, 2, 3)
-        result2 = test_function(1, 2, 3)
-        self.assertEqual(result1, result2)
-        self.assertEqual(watcher["val"], 1)
-
-    def test_memoized_on_methods(self):
-        class test_class:
-            def __init__(self, num):
-                self.num = num
-                self.watcher = 0
-
-            @memoized
-            def test_method(self, a, b, c):
-                self.watcher += 1
-                return a * b * c * self.num
-
-        instance = test_class(5)
-        result1 = instance.test_method(1, 2, 3)
-        result2 = instance.test_method(1, 2, 3)
-        self.assertEqual(result1, result2)
-        self.assertEqual(instance.watcher, 1)
-        instance.num = 10
-        self.assertEqual(result2, instance.test_method(1, 2, 3))
-
-    def test_memoized_on_methods_with_watches(self):
-        class test_class:
-            def __init__(self, x, y):
-                self.x = x
-                self.y = y
-                self.watcher = 0
-
-            @memoized(watch=("x", "y"))
-            def test_method(self, a, b, c):
-                self.watcher += 1
-                return a * b * c * self.x * self.y
-
-        instance = test_class(3, 12)
-        result1 = instance.test_method(1, 2, 3)
-        result2 = instance.test_method(1, 2, 3)
-        self.assertEqual(result1, result2)
-        self.assertEqual(instance.watcher, 1)
-        result3 = instance.test_method(2, 3, 4)
-        self.assertEqual(instance.watcher, 2)
-        result4 = instance.test_method(2, 3, 4)
-        self.assertEqual(instance.watcher, 2)
-        self.assertEqual(result3, result4)
-        self.assertNotEqual(result3, result1)
-        instance.x = 1
-        result5 = instance.test_method(2, 3, 4)
-        self.assertEqual(instance.watcher, 3)
-        self.assertNotEqual(result5, result4)
-        result6 = instance.test_method(2, 3, 4)
-        self.assertEqual(instance.watcher, 3)
-        self.assertEqual(result6, result5)
-        instance.x = 10
-        instance.y = 10
-        result7 = instance.test_method(2, 3, 4)
-        self.assertEqual(instance.watcher, 4)
-        self.assertNotEqual(result7, result6)
-        instance.x = 3
-        instance.y = 12
-        result8 = instance.test_method(1, 2, 3)
-        self.assertEqual(instance.watcher, 4)
-        self.assertEqual(result1, result8)
-
     @patch("superset.utils.core.to_adhoc", mock_to_adhoc)
     def test_convert_legacy_filters_into_adhoc_where(self):
         form_data = {"where": "a = 1"}

tests/unit_tests/memoized_tests.py

@@ -0,0 +1,96 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from pytest import mark
+
+from superset.utils.memoized import memoized
+
+
+@mark.unittest
+class TestMemoized:
+    def test_memoized_on_functions(self):
+        watcher = {"val": 0}
+
+        @memoized
+        def test_function(a, b, c):
+            watcher["val"] += 1
+            return a * b * c
+
+        result1 = test_function(1, 2, 3)
+        result2 = test_function(1, 2, 3)
+        assert result1 == result2
+        assert watcher["val"] == 1
+
+    def test_memoized_on_methods(self):
+        class test_class:
+            def __init__(self, num):
+                self.num = num
+                self.watcher = 0
+
+            @memoized
+            def test_method(self, a, b, c):
+                self.watcher += 1
+                return a * b * c * self.num
+
+        instance = test_class(5)
+        result1 = instance.test_method(1, 2, 3)
+        result2 = instance.test_method(1, 2, 3)
+        assert result1 == result2
+        assert instance.watcher == 1
+        instance.num = 10
+        assert result2 == instance.test_method(1, 2, 3)
+
+    def test_memoized_on_methods_with_watches(self):
+        class test_class:
+            def __init__(self, x, y):
+                self.x = x
+                self.y = y
+                self.watcher = 0
+
+            @memoized(watch=("x", "y"))
+            def test_method(self, a, b, c):
+                self.watcher += 1
+                return a * b * c * self.x * self.y
+
+        instance = test_class(3, 12)
+        result1 = instance.test_method(1, 2, 3)
+        result2 = instance.test_method(1, 2, 3)
+        assert result1 == result2
+        assert instance.watcher == 1
+        result3 = instance.test_method(2, 3, 4)
+        assert instance.watcher == 2
+        result4 = instance.test_method(2, 3, 4)
+        assert instance.watcher == 2
+        assert result3 == result4
+        assert result3 != result1
+        instance.x = 1
+        result5 = instance.test_method(2, 3, 4)
+        assert instance.watcher == 3
+        assert result5 != result4
+        result6 = instance.test_method(2, 3, 4)
+        assert instance.watcher == 3
+        assert result6 == result5
+        instance.x = 10
+        instance.y = 10
+        result7 = instance.test_method(2, 3, 4)
+        assert instance.watcher == 4
+        assert result7 != result6
+        instance.x = 3
+        instance.y = 12
+        result8 = instance.test_method(1, 2, 3)
+        assert instance.watcher == 4
+        assert result1 == result8