QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 01:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(plugins): replace react-icons with antd icons, remove 83MB dependency (#39184)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Maxime Beauchemin
2026-04-08 13:21:34 -07:00
committed by GitHub
parent b8b2bdedf9
commit 63cceb6a79
5 changed files with 22 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
View File

@@ -35,9 +35,11 @@ import {
Row,
} from 'react-table';
import { extent as d3Extent, max as d3Max } from 'd3-array';
import { FaSort } from 'react-icons/fa';
import { FaSortDown as FaSortDesc } from 'react-icons/fa';
import { FaSortUp as FaSortAsc } from 'react-icons/fa';
import {
CaretUpOutlined,
CaretDownOutlined,
ColumnHeightOutlined,
} from '@ant-design/icons';
import cx from 'classnames';
import {
DataRecord,
@@ -221,9 +223,9 @@ function cellBackground({
function SortIcon<D extends object>({ column }: { column: ColumnInstance<D> }) {
const { isSorted, isSortedDesc } = column;
let sortIcon = <FaSort />;
let sortIcon = <ColumnHeightOutlined />;
if (isSorted) {
sortIcon = isSortedDesc ? <FaSortDesc /> : <FaSortAsc />;
sortIcon = isSortedDesc ? <CaretDownOutlined /> : <CaretUpOutlined />;
}
return sortIcon;
}